[PATCH 1/4] resolver: support IPv4 address literals

Ian Jackson ijackson at chiark.greenend.org.uk
Sun Jul 10 23:00:06 BST 2011


Richard Kettlewell writes ("Re: [PATCH 1/4] resolver: support IPv4 address literals"):
> On 05/07/2011 12:10, Ian Jackson wrote:
> > +    const int maxlitlen=50;
> > +
> > +    int l=strlen(name);
> 
> Oh, I missed this earlier.  Will overflow if supplied with a 
> ridiculously long string (e.g. on a 64-bit platform).  Probably not a 
> big deal, but...

Yes, you're right, it should be fixed.  Shame strlen returns a
size_t ...

Ian.



More information about the sgo-software-discuss mailing list