Bug#1096840: insserv: ftbfs with GCC-15

[Mark Hindley]

Control: tags -1 upstream

Jesse,

I think this is best fixed upstream.

Mark

On Mon, Feb 17, 2025 at 05:20:07PM +0000, Matthias Klose wrote:
> Package: src:insserv
> Version: 1.26.0-1
> Severity: important
> Tags: sid forky
> User: debian-gcc at lists.debian.org
> Usertags: ftbfs-gcc-15
> 
> [This bug is NOT targeted to the upcoming trixie release]
> 
> Please keep this issue open in the bug tracker for the package it
> was filed for.  If a fix in another package is required, please
> file a bug for the other package (or clone), and add a block in this
> package. Please keep the issue open until the package can be built in
> a follow-up test rebuild.
> 
> The package fails to build in a test rebuild on at least amd64 with
> gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
> severity of this report will be raised before the forky release.
> 
> The full build log can be found at:
> http://qa-logs.debian.net/2025/02/16/amd64exp/insserv_1.26.0-1_unstable_gccexp.log.gz
> The last lines of the build log are at the end of this report.
> 
> To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
> or install the gcc, g++, gfortran, ... packages from experimental.
> 
>   apt-get -t=experimental install g++ 
> 
> GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
> Other Common build failures are new warnings resulting in build failures
> with -Werror turned on, or new/dropped symbols in Debian symbols files.
> For other C/C++ related build failures see the porting guide at
> http://gcc.gnu.org/gcc-15/porting_to.html
> 
> [...]
> Check disk space
> ----------------
> 
> Sufficient free space for build
> 
> User Environment
> ----------------
> 
> APT_CONFIG=/var/lib/sbuild/apt.conf
> HOME=/sbuild-nonexistent
> LANG=C.UTF-8
> LC_ALL=C.UTF-8
> LOGNAME=user42
> PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
> SHELL=/bin/sh
> USER=user42
> 
> dpkg-buildpackage
> -----------------
> 
> Command: dpkg-buildpackage --sanitize-env -us -uc -b
> dpkg-buildpackage: info: source package insserv
> dpkg-buildpackage: info: source version 1.26.0-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Mark Hindley <leepen at debian.org>
>  dpkg-source --before-build .
> dpkg-buildpackage: info: host architecture amd64
>  debian/rules clean
> echo -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/insserv-1.26.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/insserv-1.26.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection
> dh clean --with=bash-completion
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/build/reproducible-path/insserv-1.26.0'
> rm -f *.o *~ insserv insserv.8 config.h .depend.* .system
> rm -f insserv-1.26.0.tar.xz insserv-1.26.0.tar.xz.sig
> rm -f insserv
> rm -rf tests/root
> make[1]: Leaving directory '/build/reproducible-path/insserv-1.26.0'
>    dh_clean
>  debian/rules binary
> echo -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/insserv-1.26.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/insserv-1.26.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection
> dh binary --with=bash-completion
>    dh_update_autotools_config
>    dh_autoreconf
>    dh_auto_configure
>    dh_auto_build
> 	make -j8 "INSTALL=install --strip-program=true"
> make[1]: Entering directory '/build/reproducible-path/insserv-1.26.0'
> sed -r '\!@@BEGIN_SUSE@@!,\!@@(ELSE|END)_SUSE@@!d;\!@@(NOT|END)_SUSE@@!d' < insserv.8.in > insserv.8
> cc -W -Wall -Wunreachable-code -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/insserv-1.26.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection  -Wdate-time -D_FORTIFY_SOURCE=2   -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64  -DINITDIR=\"/etc/init.d\" -DINSCONF=\"/etc/insserv.conf\" -pipe   -c map.c
> cc -W -Wall -Wunreachable-code -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/insserv-1.26.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection  -Wdate-time -D_FORTIFY_SOURCE=2   -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64  -DINITDIR=\"/etc/init.d\" -DINSCONF=\"/etc/insserv.conf\" -pipe   -c listing.c
> In file included from map.c:9:
> listing.h:27:24: error: cannot use keyword ‘false’ as enumeration constant
>    27 | typedef enum _boolean {false, true} boolean;
>       |                        ^~~~~
> listing.h:27:24: note: ‘false’ is a keyword with ‘-std=c23’ onwards
> make[1]: *** [Makefile:102: map.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> In file included from listing.c:32:
> listing.h:27:24: error: cannot use keyword ‘false’ as enumeration constant
>    27 | typedef enum _boolean {false, true} boolean;
>       |                        ^~~~~
> listing.h:27:24: note: ‘false’ is a keyword with ‘-std=c23’ onwards
> make[1]: *** [Makefile:99: listing.o] Error 1
> make[1]: Leaving directory '/build/reproducible-path/insserv-1.26.0'
> dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
> make: *** [debian/rules:13: binary] Error 25
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2