Bug#1055645: orphan-sysvinit-scripts: Please take over mdadm init script

[tito]

On Fri, 1 Dec 2023 09:48:50 +0100
Lorenzo <plorenzo at disroot.org> wrote:

> On Fri, 1 Dec 2023 07:53:57 +0100
> tito <farmatito at tiscali.it> wrote:
> 
> > > > 
> > > > Even the cronjob is gone.
> > > 
> > > sorry, the patch does not include cronjob since o-s-s does not have
> > > a way to handle it.
> > 
> > Couldn't it be appended to crontab?
> there is no mechanism to selectively add (and remove/purge) additional
> file or snippets such as cronjobs or /etc/default/*
> 
> > Hi,
> > shouldn't /etc/default/mdadm be moved also to o-s-s?
> > I bet it is the next file to be dropped after timers
> 
> can't find the file, even in buster
> https://packages.debian.org/buster/amd64/mdadm/filelist
> 
> Well, I have it on my system but same problem as for the cronjob

Hi,
but the file is still referenced in /etc/init.d/mdadm

# grep /etc/default/mdadm /etc/init.d/mdadm*
/etc/init.d/mdadm:DEBIANCONFIG=/etc/default/mdadm

from the 5 variables set in /etc/default/mdadm:

AUTOCHECK, AUTOSCAN, VERBOSE at a first glance are ignored

 START_DAEMON has already been moved to the initscript
 so that from the /etc/default/mdadm you can only turn
the initscript off.                                  

I would propose to move  DAEMON_OPTIONS="--syslog"
to the initscript so that we can forget about /etc/default/mdadm.	 

The cronjob that will be removed soon is still a problem as it checks the arrays periodically

# By default, run at 00:57 on every Sunday, but do nothing unless the day of
# the month is less than or equal to 7. Thus, only run on the first Sunday of
# each month. crontab(5) sucks, unfortunately, in this regard; therefore this
# hack (see #380425).
57 0 * * 0 root if [ -x /usr/share/mdadm/checkarray ] && [ $(date +\%d) -le 7 ]; then /usr/share/mdadm/checkarray --cron --all --idle --quiet; fi

There will be other cron jobs like this that will be susbtituted by systemd timers
so we need to find how to handle this.

Ciao,
Tito

> 
> $ cat /etc/default/mdadm 
> # mdadm Debian configuration
> #
> # You can run 'dpkg-reconfigure mdadm' to modify the values in this file, if
> # you want. You can also change the values here and changes will be preserved.
> # Do note that only the values are preserved; the rest of the file is
> # rewritten.
> #
> 
> # AUTOCHECK:
> #   should mdadm run periodic redundancy checks over your arrays? See
> #   /etc/cron.d/mdadm.
> AUTOCHECK=true
> 
> # AUTOSCAN:
> #   should mdadm check once a day for degraded arrays? See
> #   /lib/systemd/system/mdmonitor-oneshot.service
> AUTOSCAN=true
> 
> # START_DAEMON:
> #   should mdadm start the MD monitoring daemon during boot?
> START_DAEMON=true
> 
> # DAEMON_OPTIONS:
> #   additional options to pass to the daemon.
> DAEMON_OPTIONS="--syslog"
> 
> # VERBOSE:
> #   if this variable is set to true, mdadm will be a little more verbose e.g.
> #   when creating the initramfs.
> VERBOSE=false
> 
> 
> Lorenzo
> 
> >  
> > Ciao,
> > Tito
>