src:sysvinit 3.00~beta-1 review

[Adam Borowski]

On Mon, Sep 13, 2021 at 11:58:50AM +0100, Mark Hindley wrote:
> I have just pushed src:sysvinit branch wip/leepen. I would appreciate review and
> comments.
> 
> In addition to updating to upstream version 3.00~beta, I have merged most of
> Trek's init-d-script patches that were sent to the list last year and tried to
> pick off the low hanging fruit on the BTS (mainly recentish reports with
> patches).
> 
> Jesse intends to release 3.00 within a couple of weeks and does not anticipate
> any material changes at this stage.

No explosions on my boxen so far; as for reading the code I've only skimmed
through it so far -- not noticing any badness.  (Non-trivial that is,
upstream's whitespace at line ends sucks! :p)

I did only superficial testing so far.

> Are there other issues that should be addressed at this stage?

Could you please put what you have into experimental?  That'd make it more
convenient to test more platforms, and would also make further diffs more
digestible.

And for extra changes it's better to base them on a fixed version.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ If you ponder doing what Jesus did, remember than flipping tables
⢿⡄⠘⠷⠚⠋⠀ and chasing people with a whip is a prime choice.
⠈⠳⣄⠀⠀⠀⠀