Bug#670585: "ok hat location is writable"

[Tito]

On 5/5/19 9:41 PM, Dmitry Bogatov wrote:
> 
> control: usertags -1 +objections
> 
> [2019-05-02 22:00] Antoni Villalonga <antoni at friki.cat>
>> I've found the message here:
>>
>> /etc/rcS.d/S10checkfs.sh
>> 124 log_success_msg "Done checking file systems.
>> 125     A log is being saved in ${FSCK_LOGFILE} if that location is writable."
>>
>> I think the console width was 80 chars and it caused "if that location..."
>> message drop to next line. After that, "[ ok " message overwrited from the
>> beggining of the line, causing the anoying message.
> 
>> If this problem is meant to be "fixed"? Shorter messages (if any) may
>> be the easy way.
> 
> Thank you for suggestion. I managed reproduce similar (but not exactly
> same) glitch with long line and 80 column wide terminal.
> 
> I believe following patch, that splits and slightly rewords message
> should fix issue. Second part is still quite long -- long enough to fill
> exactly 80 columns, but I have no idea how to shorten it futher.
> Opinions?
> 
>  From 2799d371c413b9c606e968eb61f94711ce70cd4f Mon Sep 17 00:00:00 2001
> From: Dmitry Bogatov <KAction at debian.org>
> Date: Fri, 3 May 2019 17:21:17 +0000
> Subject: [PATCH] Split long message into several lines
> 
> Long message on 80-column may cause visual glitches due interation of
> terminal control characters and newline breaking, so it is safer to
> make sure that no argument to 'log_{success,warning,error}_msg' is
> no longer than 70 characters (generously leaving 10 characters for colored
> ok/warn/error marker on the left).
> 
> Closes: #670585
> Thanks: Antoni Villalonga <antoni at friki.cat>
> ---
>   debian/src/initscripts/etc/init.d/checkfs.sh | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/debian/src/initscripts/etc/init.d/checkfs.sh b/debian/src/initscripts/etc/init.d/checkfs.sh
> index 13a10d10..67929dec 100755
> --- a/debian/src/initscripts/etc/init.d/checkfs.sh
> +++ b/debian/src/initscripts/etc/init.d/checkfs.sh
> @@ -121,8 +121,8 @@ Continuing with system boot in 5 seconds."
>   			then
>   				handle_failed_fsck
>   			else
> -				log_success_msg "Done checking file systems.
> -A log is being saved in ${FSCK_LOGFILE} if that location is writable."
> +				log_success_msg 'Done checking file systems'
> +				log_success_msg "Log is being saved in ${FSCK_LOGFILE} if that location is writable"
>   			fi
>   		fi
>   	fi
> 
> 
> 
> 

Hi,
maybe something like:

if test -w ${FSCK_LOGFILE} ; then
	log_success_msg "Log is saved in ${FSCK_LOGFILE}
else
	log_success_msg "Cannot save log in ${FSCK_LOGFILE}
fi

Ciao,
Tito