Bug#924792: pidof: unsanitized user input makes pidof crash

Jesse Smith jsmith at resonatingmedia.com
Wed Mar 20 00:29:55 GMT 2019

On 3/19/19 7:28 PM, KatolaZ wrote:
> On Tue, Mar 19, 2019 at 05:54:56PM -0300, Jesse Smith wrote:
>> I am certainly open to replacing the "format" flag (-f) with an
>> alternative field separator flag. It has a nice Unixy feel to it and
>> requires less code.
>> Personally, I think using -d (or --delimiter) might be the only change
>> I'd want to make to the patch KatolaZ provided. Partly because pidof
>> already has a lower-case "-s" flag and I want to avoid confusion, and
>> because tools like cut also use "-d".
>> If there are no objections, I'll upstream KatolaZ's patch and remove the
>> "-f" flag.
> No objections on my side.  '-d' makes sense to me as well.
> @Jesse: I feel I owe you an apology. I read again my first post in
> this thread, and I noticed that it might have sounded harsh, or worse,
> patronising. Sorry: that was never my intention.  I hope you can
> accept my apologies.

Not to worry, and no apology necessary. You raised a valid point about
over-engineering pidof and made some constructive criticism. I
appreciate you helping to come up with a better solution.


More information about the Debian-init-diversity mailing list