Bug#931165: startpar FTCBFS: build for the wrong architecture

[Nguyen Hoang Tung]

Hi Helmut,

Thanks for your comments. I updated the patch.


Thanks and best regards,
Tungnh

-----Original Message-----
From: Helmut Grohne [mailto:helmut at subdivi.de] 
Sent: Friday, June 28, 2019 11:16 AM
To: Nguyen Hoang Tung; 931165-maintonly at bugs.debian.org
Subject: Re: Bug#931165: startpar FTCBFS: build for the wrong architecture

On Thu, Jun 27, 2019 at 03:35:31PM +0700, Nguyen Hoang Tung wrote:
> startpar fails to cross build because it does not pass cross build 
> tools to make. Using "dh_auto_build" instead of "$(MAKE)" can solve this
problem.

Good catch. 0.59-4 still crossed, so this is a regression. I have two minor
issues to be found when looking deeper.

The file that fais building (compiletest.cc) seems entirely useless.  I see
no use of this testfunc in startpar.  Dropping CXXSRCS from OBJS in Makefile
should fix this problem as well.

Then replacing $(MAKE) with dh_auto_build is a nice cleanup irrespective of
fixing cross building. When doing so you can also clean the CC=$(CC)
assignment there and the construction of CC earlier. This dates back to a
time when dh_auto_build didn't pass cross tools.

Helmut

--
This mail was scanned by BitDefender
For more information please visit http://www.bitdefender.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: startpar_crossbuild.debdiff
Type: application/octet-stream
Size: 780 bytes
Desc: not available
URL: <http://www.chiark.greenend.org.uk/pipermail/debian-init-diversity/attachments/20190628/d54bcf9b/attachment.obj>
-------------- next part --------------
-- 
This mail was scanned by BitDefender
For more information please visit http://www.bitdefender.com