Bug#928250: sysv-rc: make depend on "lsb-base"

Dmitry Bogatov KAction at debian.org
Tue Apr 30 16:03:20 BST 2019


Source: sysvinit
Version: 2.94-2
Severity: wishlist


 From d754b4a470bc7f5bf3b04beb0a18c6b2895f8f8a Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <KAction at debian.org>
Date: Mon, 29 Apr 2019 02:49:32 +0000
Subject: [PATCH] Make lsb-base hard dependency of sysv-rc

Since "initscripts" package already depends on "lsb-base", and sysv-rc
is used almost exclusively with "initscripts", there is no point in having
it soft (recommends) dependency on "lsb-base".

Now, with "lsb-base" as hard dependency of "sysv-rc", /etc/init.d/rc
script, provided by "sysv-rc", could be simplified: there is no longer
need to check, whether file /lib/lsb/init-functions exists.
---
 debian/control        | 3 +--
 debian/src/sysv-rc/rc | 8 +-------
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/debian/control b/debian/control
index 06c59aef..1e24709e 100644
--- a/debian/control
+++ b/debian/control
@@ -69,12 +69,11 @@ Description: System-V-like utilities
 Package: sysv-rc
 Architecture: all
 Multi-Arch: foreign
-Recommends:
- lsb-base (>= 3.2-14),
 Pre-Depends:
  init-system-helpers (>= 1.25~),
 Depends:
  insserv (>> 1.12.0-10),
+ lsb-base (>= 3.2-14),
  startpar,
  sysvinit-utils (>= 2.86.ds1-62),
  ${misc:Depends},
diff --git a/debian/src/sysv-rc/rc b/debian/src/sysv-rc/rc
index d36ecc75..ed828cf5 100755
--- a/debian/src/sysv-rc/rc
+++ b/debian/src/sysv-rc/rc
@@ -56,13 +56,7 @@ if [ -f /etc/default/rcS ] ; then
 fi
 export VERBOSE

-if [ -f /lib/lsb/init-functions ] ; then
-	. /lib/lsb/init-functions
-else
-	log_action_msg() { echo $@; }
-	log_failure_msg() { echo $@; }
-	log_warning_msg() { echo $@; }
-fi
+. /lib/lsb/init-functions

 #
 # Check if we are able to use make like booting.  It require the
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://www.chiark.greenend.org.uk/pipermail/debian-init-diversity/attachments/20190430/c324cc36/attachment.sig>


More information about the Debian-init-diversity mailing list