Bug#926547: insserv: tests/run-tests are not used

[Dmitry Bogatov]

Package: insserv
Version: 1.18.0-2
Severity: normal

Dear upstream maintainer,

during preparation of debian package of insserv=1.19.0 I discovered
issue with test suite (tests/run-tests), which was imported from
`debian/run-tests'.

Firstly, this test suite is not run by Makefile:

	check: insserv
	ifeq ($(ISSUSE),-DSUSE)
		issuse=true tests/common
	#	issuse=true tests/suse
	else
		tests/common
	endif

If I try to execute them myself, I get following error:

	$ tests/run-testsuite
	[...]
	./tests/run-testsuite: line 982: _order: command not found
	error: 88 test executed, 3 fatal tests failed, 1 nonfatal test failed.

Looking up line 982 reveals following:

	${severity}_order S mountall needlocal

with `severity' variable is not set anywhere in script. If I set it
myself, like

	$ severity=check ./tests/run-testsuite
	[...]
	error: 244 test executed, 3 fatal tests failed, 3 nonfatal test failed.

I get more sensible output, but still 6 tests are failing.

@Jesse, could you please take a look and maybe cut another upstream
release?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://www.chiark.greenend.org.uk/pipermail/debian-init-diversity/attachments/20190406/94b0acf3/attachment.sig>