Bug#916212: elogind: when upgrading /run/elogind.pid believed even if actual process had died

[Mark Hindley]

On Wed, Dec 12, 2018 at 12:54:42AM +1030, Arthur Marsh wrote:
> Package: elogind
> Version: 239.3-1
> Severity: normal
> 
> Dear Maintainer,
> 
> *** Reporter, please consider answering these questions, where appropriate ***
> 
>    * What led up to the situation?
> 
> aptitude upgrade:
> 
> [UPGRADE] elogind:amd64 239.1+20181115-1 -> 239.3-1
> [UPGRADE] libelogind0:amd64 239.1+20181115-1 -> 239.3-1
> [UPGRADE] libpam-elogind:amd64 239.1+20181115-1 -> 239.3-1
> 
>    * What exactly did you do (or not do) that was effective (or
>      ineffective)?
> 
> When attempting to restart the new version of elogind, there would
> be an error message based on the existence of the /run/elogind.pid file,
> even when the process did not exist. I had to manually remove
> /run/elogind.pid to be able to start the new elogind

Arthur. Could you try this patch and verify it fixes this issue for you?

Thanks

Mark

--- a/src/login/elogind.c
+++ b/src/login/elogind.c
@@ -179,8 +179,8 @@
                 get_process_comm(pid, &comm);
                 if (NULL == startswith(strna(comm), program_invocation_short_name))
                         goto we_are_alone;
+                return pid;
         }
-        return pid;
 
 we_are_alone: