Oopsie in sysvinit-2.92

[KatolaZ]

On Mon, Nov 26, 2018 at 05:11:43PM +0000, Dmitry Bogatov wrote:

[cut]


> > [ KatolaZ ]
> > If it is not, I would appreciate concrete comments instead. Anything
> > can be improved in many different ways, and if you are not told what
> > is wrong, any "improvement" might just be bad without you realising
> > it.
> 
> Correct. Let me elaborate (see links above):
> 
>  * Subject of commit message should be capitalized and in present tense.
>      'amended changelog' -> 'Amend changelog'
>      'incorporated'      -> 'incorporate'
>      'applied'           -> 'apply'
> 
>  * There is quite wide-spread convention, that changelog entry for new
>    release is 'New upstream release' or 'New upstream version'.


Sorry for the late reply, busy week. Fine, will stick to that.

[cut]

> 
> I never doubted your good faith. But `debchange -a' insert proper
> attribution automatically.
>

Cool.

[cut]

> 
> Commit message of revert commit (0a6d64):
> 
>     This commit reverts set of commits, that includes improper import of
>     upstream release. Import of upstream release should be done as merge
>     with upstream branch (`upstream' by default, `upstream-release' as
>     configured in `debian/gbp.conf').
> 
> I wrote about it above.
> 
>     There is nothing wrong with patch to fix behavior of `pidof', but since
>     upstream release 2.93 is already released, that contains that fix, it is
>     simplier to just package and upload sysvinit-2.93.
> 
> Here, as you see, I do not object aganist your commit 5b14.
> 
> It would be perfectly fine to leave it as-is, and instead remove that
> patch at commit, introducing upstream release 2.93. This patch will not
> be mentioned in `debian/changelog', since it was never uploaded. I am
> okay with doing it that way.
> 
> You are welcome to propose improvements to my wording.
>

Let's go with 2.93 then. It looks like the cleaner option to me as
well.

Regards

KatolaZ

-- 
[ ~.,_  Enzo Nicosia aka KatolaZ - Devuan -- Freaknet Medialab  ]  
[     "+.  katolaz [at] freaknet.org --- katolaz [at] yahoo.it  ]
[       @)   http://kalos.mine.nu ---  Devuan GNU + Linux User  ]
[     @@)  http://maths.qmul.ac.uk/~vnicosia --  GPG: 0B5F062F  ] 
[ (@@@)  Twitter: @KatolaZ - skype: katolaz -- github: KatolaZ  ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://www.chiark.greenend.org.uk/pipermail/debian-init-diversity/attachments/20181202/9b6b0d25/attachment.sig>